Skip to content

Conversation

@uis246
Copy link

@uis246 uis246 commented Nov 9, 2020

No description provided.

@djdeath
Copy link
Collaborator

djdeath commented Nov 9, 2020

Protobuf might not always be available on the distro used, so I think it's much better to bundle our own version.

@uis246
Copy link
Author

uis246 commented Nov 9, 2020

Not always, but when avaliable use system one, when either protobuf-c or protoc unavaliable - fallback to bundled protobuf

@djdeath
Copy link
Collaborator

djdeath commented Nov 9, 2020

But what's the advantage? I see more problems of compatibility to deal with.

@uis246
Copy link
Author

uis246 commented Nov 10, 2020

Because system protobuf and bundled can conflict. Because when protobuf installed, gcc prefer headers of system one, but link with bundled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants