modify ToCamelCase mehtod to support PascalCase strings#8
Open
JNeisa wants to merge 2 commits intorhythmagency:v2/mainfrom
Open
modify ToCamelCase mehtod to support PascalCase strings#8JNeisa wants to merge 2 commits intorhythmagency:v2/mainfrom
JNeisa wants to merge 2 commits intorhythmagency:v2/mainfrom
Conversation
Nicholas-Westby
suggested changes
May 30, 2023
Contributor
Nicholas-Westby
left a comment
Nicholas-Westby
left a comment
There was a problem hiding this comment.
Just one change regarding the tests. See inline comment.
src/Tests/StringTests.cs
Outdated
| public void PascalCase() | ||
| [DataRow("hello-world-test", "helloWorldTest")] | ||
| [DataRow("HelloWorldTest", "helloWorldTest")] | ||
| public void CamelCase(string input, string expected) |
Contributor
There was a problem hiding this comment.
Seems like you've removed the PascalCase test method, which should not have happened. If anything, you can add the CamelCase method while leaving the PascalCase method untouched. Also, I recommend adding a data row for a single letter to ensure it doesn't throw an error (since I see there is new logic that concatenates the first letter followed by everything else).
Author
There was a problem hiding this comment.
Sure! It is done right now, please take a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #7 issue