Reverted move of x11grab video input to left side of pipe #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as causing raw video data to be passed through the pipe, resulting in very poor framerate. Kept restructuring of variables to build ffmpeg options/arguments. Issue rfht#10
This was referenced Oct 5, 2025
Contributor
|
can confirm. this fixes the low quality issue on my machine with vaapi and without |
Contributor
Author
|
@Izder456 Many thanks for testing and confirming, especially both with and without VA-API! |
rfht
approved these changes
Nov 14, 2025
Owner
|
Thanks for the find! |
Owner
|
To explain where this came from - the move of x11grab to the left side of the pipe was an attempt to grab video and audio at the same time in the hopes that this would fix the desync issues. It looks like that was not the solution, and mainly led to video quality impairment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the regression of video quality (see issue #10), which I found to occur even when not using VA-API.
Specifically, it reverts the move of x11grab video capture to left side of pipe. My hypothesis is that this causes the raw video data to be passed through the pipe, to then be encoded on the other side, resulting in lots of extra memory reads & writes before encoding, and manifesting as very poor frame rate. It does keep the nice new restructuring of variables to build ffmpeg options/arguments.