Develop #7
Open
Develop #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks on profile
…etize-permits-errors Permit errors when concretizing workspace
This commit adds a config option to allow environment variables to passthrough from the user environment into the execution environment when using `ramble on`.
…ars-in-exec Add env-var passthrough option
Avoid direct access to variables in slurm workflow manager
It'd be even better to do the expansion upon `add_criteria`. However the expander isn't available at the workspace level. And the fom_comparison isn't tied to a file so incurs much less overhead than file_foms. Incidentally remove some unused imports in the tests.
This commit adds a test that currently fails in the expander, for expanding an already formatted dictionary.
This commit updates the way the expander detects keywords and format specifiers to use a regular expression to match valid format specifiers, instead of simply splitting on colons. This is a more robust way, that allows formatted dictionarieis to function properly.
Avoid unnecessary repeated expansion
experiment_run_dir
promote upload print to be more visible
…t-format-specifiers Update format specifier extraction to be more robust
Adds a slurm-pyxis workflow manager to add pyxis-specific srun args to the experiment command when using Slurm.
…clause Add support for variants, a when clause, and the default_args clause
Add a modifier to support running experiment from a directory other than experiment_run_dir
This PR fixes two things: 1. Duplicated code in workspace that outputs software info 2. Adds code to handle the case where packages are empty
…ache Enable push to cache to push compilers
This PR fixes two things: 1. Duplicated code in workspace that outputs software info 2. Adds code to handle the case where packages are empty
This commit fixes an issue where format specifier errors would inject additional curly braces.
This commit fixes the construction of the `application_name` variant to include application names from base classes.
Adds support for 'when' to register_builtin directive. Adds a generalized unpacking of 'when' in workspace info.
Add py-espresso application definition
…uiltin_when Add `when` to register_builtin
This commit adds an argument to `ramble workspace archive` which allows additional patterns to be specified (relative to the workspace root) which will be included in the archive.
…ive-pattern-args Allow `workspace archive` to accept additional patterns to archive
Do not fail analyze due to an app has no FOM defined
add simple documentation for ramble workspace manage
…-variables Allow `when` on all variable types
Add tests for attributes `ramble commands`
Fix docker image env -- correctly loads spack now
This updates the execution (ditching the wrapper) as well as adding a coupel FOMs. The changes are based on the usage I see from su2 users.
…m-application Add NVIDIA dcgm diagnostics application
Update su2 application
Previously, a commit changed the logic to assume all modifier variables were considered not expandable. This fixes that logic.
…no-expand-vars Fix incorrect definition for no_expand_vars in modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.