feat: pass evm config to pool components builder #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
commented
Jan 24, 2026
| + FromRecoveredTx<TxTy<Self::Primitives>> | ||
| + FromTxWithEncoded<TxTy<Self::Primitives>>, | ||
| Precompiles = PrecompilesMap, | ||
| Spec: Into<SpecId>, |
Author
There was a problem hiding this comment.
this is enforced by revm's Cfg trait so practically any evm spec likely implements this
mattsse
reviewed
Jan 25, 2026
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
while this changes some apis, I think this is the right deisgn because pool validation is kinda closely coupled with the evm now or at least we want to make this easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the EVM config to the pool components builder, allowing pool validation to use configurable EVM execution limits.
targets paradigmxyz#21088