refactor: enforced with_limits demo #7
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
ConfigureEvmto enforce that EVM limits are always applied, eliminating the risk of SDK users forgetting to call.with_limits()in their custom implementations.Problem: Previously, implementors of
ConfigureEvmhad to manually call.with_limits()in bothevm_env()andnext_evm_env(). This made it easy to forget to apply limits.Solution: Introduces a template method pattern:
evm_env_without_limits()andnext_evm_env_without_limits()as required methods that return the base environmentevm_env()andnext_evm_env()now have default implementations that automatically apply limitsevm_limit_params_at_timestamp()as a required method to provide limitsNextBlockTimestamptrait to enable accessing timestamp fromNextBlockEnvCtxNOTE: This impl is missing equivalent for ConfigureEngineEvm