Skip to content

Suggestions#101

Open
mdkeehan wants to merge 3 commits intoreworkhow:masterfrom
mdkeehan:suggestions
Open

Suggestions#101
mdkeehan wants to merge 3 commits intoreworkhow:masterfrom
mdkeehan:suggestions

Conversation

@mdkeehan
Copy link
Copy Markdown

I tried to track down why the Unit Tests for XSim were failing and ended up looking quite closely at some parts of JWAS on the way. I have made a few suggestions which I have included as a pull request. The only testing I have done is the JWAS unit tests and running under Julia 1.6.3.

  1. The worst error was that mme.Lhs eventually became a Sparsevector of {Any} which does not have an associated zero() function.
  2. A deprecation warning was fixed
  3. genotypes were simplified to be read as Float32 to which they were eventually converted.

@reworkhow
Copy link
Copy Markdown
Owner

Hi Mike, this is great! I will look into your pull request and merge it this week.

@mdkeehan
Copy link
Copy Markdown
Author

mdkeehan commented Nov 2, 2021

Hi Hao,

I have thought about this some more. The third commit 78c5faf is a large style change and interacts with commit da6d2ee. Parts of 78c5faf may be redundant once da6d2ee has gone in.
Happy to see what you think and I hope they are useful!

Mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants