rbtools should declare setuptools as a requirement

[jmcrawford45]

rbtools uses pkg_resources which is provided by setuptools. Since this dependency isn't declared, my builds fail due to "ModuleNotFoundError: No module named 'pkg_resources'"

[chipx86]

Thanks for the change. I'd be interested in knowing at which point it fails and what your environment looks like, since setuptools is considered a per-requisite before interacting with setup.py.

As for code contributions, all code review is done on https://reviews.reviewboard.org, rather than through pull requests.

[jmcrawford45]

Hi Christian, This fails for me anytime at runtime when a pkg_resources import is attempted <https://github.com/reviewboard/rbtools/search?q=pkg_resources>. My environment creates wheels that are then resolved into a PEX <https://github.com/pantsbuild/pex>. Per https://www.python.org/dev/peps/pep-0518/#build-system-table, setuptools is an implicit requirement for builds, but not for installs. I'm unable to run rbt to post to reviewboard since the certificate's issuing CA isn't trusted by my distribution, and when I --disable-ssl-verification to bypass, I get a 401 incorrect password even when providing the correct username / password pair (I verified this by successfully logging in via browser with this pair).

…

On Tue, Jan 11, 2022 at 10:17 PM Christian Hammond ***@***.***> wrote: Thanks for the change. I'd be interested in knowing at which point it fails and what your environment looks like, since setuptools is considered a per-requisite before interacting with setup.py. As for code contributions, all code review is done on https://reviews.reviewboard.org, rather than through pull requests. — Reply to this email directly, view it on GitHub <#74 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEEPWXGPPCZGSKDVUDVAL2LUVT6EDANCNFSM5LX62IHA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[nekopsykose]

setuptools is considered a per-requisite before interacting with setup.py.

that is 'build time'; it uses pkg_resources at runtime, after installing, so it's an install dependency and has to be specified as such.

also note that this is explicitly deprecated since setuptools 67.5.0 https://github.com/pypa/setuptools/blob/be6c0218bcba78dbd4ea0b5a8bb9acd5d5306240/CHANGES.rst#v6750

importlib.resources/metadata are the intended stdlib replacement (and have backport packages for pre-3.7/3.8 respectively), but i'm not sure what the replacement for iter_entry_points is.