Open
Conversation
This reverts commit 85a123c.
Author
|
the reasoning for writing this is bc, i cannot locate the restore function in the codebase, can you tell me which file it is located in? also the reasoning i named it soft_restore is to follow the naming schema of the codebase and to prevent code clashes from other using librarys that might have the restore function defined. |
Matsa59
reviewed
Nov 22, 2023
Matsa59
approved these changes
Feb 12, 2024
Matsa59
left a comment
Matsa59
left a comment
There was a problem hiding this comment.
The code looks good.
For tests, dunno what to recommend, maybe the maintainer should take a look and suggest a new test strategy
Co-authored-by: Alexandre Lepretre <alexandre.lprtr@gmail.com>
mithereal
commented
Feb 12, 2024
Author
mithereal
left a comment
mithereal
left a comment
There was a problem hiding this comment.
should be good now i removed the index that was not necessary and cleaned up the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the inverse functions of soft delete by setting deleted_at field to nil