Conversation
reu
reviewed
Jan 28, 2025
Owner
reu
left a comment
reu
left a comment
There was a problem hiding this comment.
That's some excellent work! Just a requesting a minor change but besides that this is ready to go! Thanks!
petoknm
force-pushed
the
optional-threadpool
branch
from
e47096e to
a7d02c3
Compare
Contributor
Author
|
The CI jobs scripts might need a tweak, currently they use |
Owner
|
Thanks a lot @petoknm, looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using touche in single threaded mode and I was expecting that my config (below) would eliminate the code from threadpool crate if unused, but it was not able to completely remove it. I assume this was because of some use of it in
Servertype.With this MR, I was able to fully eliminate threadpool crate's code from my final binary.