Open
Conversation
Unless the `threadpool` feature is disabled, `Server` always contains a thread pool, even if it is unnecessary because the `Server` is only used with `serve_single_thread`. Fix this by deferring creating the thread pool until it is actually required. I noticed this because I was getting resource exhaustion errors when running a single-threaded server in a podman container, which restricts the number of threads. Disabling the `threadpool` feature also fixes this, but this must be done explicitly since it's a default feature.
Fix clippy warnings about replacing `io::Error::new(io::ErrorKind::Other, ...)` with `io::Error::other(...)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless the
threadpoolfeature is disabled,Serveralways contains a thread pool, even if it is unnecessary because theServeris only used withserve_single_thread. Fix this by deferring creating the thread pool until it is actually required.I noticed this because I was getting resource exhaustion errors when running a single-threaded server in a podman container, which restricts the number of threads. Disabling the
threadpoolfeature also fixes this, but this must be done explicitly since it's a default feature.Also:
Fix clippy warnings about replacing
io::Error::new(io::ErrorKind::Other, ...)withio::Error::other(...).