Open
Conversation
…e (worse than MC)
…r and faster. All tests pass
Open
Contributor
Author
|
Oh I should also mention, the function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for representing distributions numerically. The PR includes documentation on how exactly it works, see doc/source/numeric_distributions.rst. So I will just summarize the changes.
When people do cost-effectiveness analyses or other sorts of Fermi estimates, if they incorporate uncertainty at all, they almost always use Monte Carlo sampling. Numerically representing probability distributions as histograms is usually much more accurate at a given level of speed (or, equivalently, much faster at a given level of accuracy), so it kind of bugs me that people hardly ever use numeric methods. But as far as I know, there aren't any good tools for numeric methods, and it's a bit tricky to implement from scratch: not difficult in the grand scheme of things, but more involved than writing a Monte Carlo simulation, which you can do in only a few lines of code. So I decided to extend Squigglepy to support numeric methods.
I hope to reproduce this PR in Squiggle since Squiggle is actively supported and more widely used, but I did it in Squigglepy first because I thought it would be simpler (especially because Python has good numeric libraries).
An overview of supported features:
QA