Return unformatted response if parser fails #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbeach
force-pushed
the
handle-parsing-error
branch
4 times, most recently
from
f6c84d7 to
5043702
Compare
Adds error handling for formatting. Just shows the raw response when formatting fails. I deal with some API's that will report they're returning `application/json` and then proceed to just return plain text.
jmbeach
force-pushed
the
handle-parsing-error
branch
from
5043702 to
bddbc18
Compare
jmbeach
changed the title
jmbeach
requested review from
NTBBloodbath and
boltlessengineer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error handling for formatting. Just shows the raw response when
formatting fails.
I deal with some API's that will report they're returning
application/jsonand then proceed to just return plain text.