Add base Job class #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhunsaker
reviewed
Mar 5, 2025
danhunsaker
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
Resque\Job\JobInterfacewith an abstractResque\Job\Jobclass. The abstract class is much more useful, as we can define the properties that we set on Jobs (which fixes deprecation warnings with PHP 8.2), as well as provide default implementation forsetUp()andtearDown().The one behavior change here is that I changed
perform()from a boolean return value to void. The actual impact here is minimal, as it would only affect Jobs that chose to returnfalsefor some reason. There was no unit test for such a case, so I don't think it's a problem.