build(nel0x): add bundleRelease

[researchxxl]

@nel0x

[nel0x]

Looks fine to me 👍 Will try it out when the next release is ready

[researchxxl]

@nel0x https://github.com/researchxxl/syncthing-android/actions/runs/20578781418 contains the unsigned-bundle artifact
appreciate your review if that is what you need or what adjustments you require to fit your workflow :))

i cant see the google play side.. would you be so kind and test if this is play fitting??

[nel0x]

I can't directly do a code suggestion but can we add add _gplay_v${{ env.VERSION }}_${{ env.COMMIT_HASH }} to the artefact file name?
I think it makes it a lot nicer/more distinct, but maybe that's only possible for release.yml as - if I see correctly - common-build.yaml doesn't alway have a version tag associated when executed, right?

Other than that it seems perfectly fine, GPlay doesn't criticize anything on upload.

[researchxxl]

I can't directly do a code suggestion

just checkout branch and start a pr?? you can then edit freely

can we add add gplay_v${{ env.VERSION }}${{ env.COMMIT_HASH }}

if you really want it -- yes.. but atm it is just an artifact and not released to the user.. i kept in mind this is only needed for you to upload to google gplay right??

what is your opinion on releasing the artifacts?? should we do separate tags eg v1.0.0.0-gplay which fdroid does not pick up and show the artifact there.. probably using a sep release action and signing?? or all in one and link a wiki article telling users which artifact is for whom??

common-build.yaml doesn't alway have a version tag associated when executed, right?

it can also point to a commit sha256 which makes testing easier for us because tags are immutable on releases ;))
but thats not a problem.. the common-build reads the app version from the repo at the specified tag or commit so we have that if you want it

feel free to pr what fits best in your eyes and i'll merge it for you :))

you might like to change the common-build step "Rename unsigned release artifacts" as well

[researchxxl]

@nel0x can i help you on sth or do you just need time to react to my latest review?? btw if i read your last comment correct you are already fine with the built bundlerelease artifact.. so pls feel free to release v2.0.13.0 along with us :)) i have triggered the build for you here https://github.com/researchxxl/syncthing-android/actions/runs/20782627009/artifacts/5049573362

[nel0x]

The build works thanks, but the main issue is that versions after 2.0.11.1 suffer from #60. Unfortunately, I won't have time to fix the root access this month. If we push this to GPlay, we'll propagate this bug to all users. I'm unsure if it's worth releasing in this state, what do you think?

[researchxxl]

@nel0x yeah that is a classic mismatch in the roadmap.. would have suggested to point this out in the update notes to users but still dangerous because of users begin optin to google auto updating their apps :/.. if you are not in a hurry pls take your time.. atm it is your right and decision to deprecate root or fix it when you have time

i guess the user count with root is not that high to justify a new release variant here that includes root??

[nel0x]

i guess the user count with root is not that high to justify a new release variant here that includes root??

I don't think it's worth it too, especially since those affected users would still need to reinstall the app manually.

I mean in the end - as long as their isn't a critical bugfix or vulnerability - probably >99% of the users on mobile don't care if they are on the absolute latest version.
But of course it would be nice to have the new versions on GPlay too in the foreseeable future ...

[researchxxl]

@nel0x pls see my draft #107 and feel free to help if your time permits later to refactor and test the root feature.. i have made up my mind and imo the correct way to bring the feature back is to do the refactor with a secure dependency and test together with the community :)) as soon it reaches good review and stability we will merge it into main

dependencies have full access to the devices root and storage features just our own app code has and should be chosen carefully and security wise.. i did not want to offend any user when i whipped off the outdated code parts

[boomshankerx]

This is a friendly reminder that this issue is holding up the battery drain issue fix. Unfortunately updating via apk doesn't seem to update the play store version.