Replace tinystl with stl_io to support more stl files#9997
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
please make sure to test this with a wide variety of STL files |
Wumpf
left a comment
There was a problem hiding this comment.
See comments above. Thanks for the manual testing earlier (Slack message pointed out testing done!), but a bit of that has to be redone with the proposed improvements
a19ed66 to
4d987f4
Compare
There was a problem hiding this comment.
This library makes me unhappy since I don't think its datastructures make any sense in the context of STL. But whatever, if we ever care deeply about loading performance here, we can fork it proper later. It loading more files is obviously more important!
good to land if collect issue & crate question are addressed!
What
This replaces
tinystlwithstl_ioin our stl parser, because some binary stl files (e.g. g1 right_wrist_yaw_link.STL) could not be parsed, resulting in a warning:Using
stl_iothis mesh is parsed correctly.TODO:
stl_iodoes not expose this field. This is in line with the behavior oftinystlfor meshes without a name. I opened a PR that exposes the mesh name: Add optional mesh name hmeyer/stl_io#26