Skip to content

Conversation

@area73
Copy link
Collaborator

@area73 area73 commented Jan 6, 2026

  • Commented out the environment variable for PUBLIC_GA_MEASUREMENT_ID in the E2E-Tests job of ci.yml.
  • Added the PUBLIC_GA_MEASUREMENT_ID environment variable to the Build-App job in ci.yml.
  • Removed TypeScript error suppression comment in the GoogleAnalytics.astro component for cleaner code.

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration to modify Google Analytics environment variable handling in test environments.
    • Removed TypeScript linting directive from the Google Analytics component for improved code clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

- Commented out the environment variable for PUBLIC_GA_MEASUREMENT_ID in the E2E-Tests job of ci.yml.
- Added the PUBLIC_GA_MEASUREMENT_ID environment variable to the Build-App job in ci.yml.
- Removed TypeScript error suppression comment in the GoogleAnalytics.astro component for cleaner code.
@cursor
Copy link

cursor bot commented Jan 6, 2026

PR Summary

Focuses GA configuration on build and simplifies the GA component.

  • CI: Comment out PUBLIC_GA_MEASUREMENT_ID in E2E-Tests and Visual-Regression-Tests; add PUBLIC_GA_MEASUREMENT_ID env and a validation step to Build (now dependent on Lint/Type/Unit/E2E); retain GA validation in visual tests
  • src/components/GoogleAnalytics.astro: remove @ts-expect-error and keep async, low-priority GA script loading and inline config

Written by Cursor Bugbot for commit 5a09cd2. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Changes primarily focus on configuration adjustments to Google Analytics measurement ID handling in CI/CD workflows and removal of a TypeScript error suppression comment from the GoogleAnalytics component, with no functional behavior modifications.

Changes

Cohort / File(s) Summary
Google Analytics Configuration & Cleanup
​.github/workflows/ci.yml, src/components/GoogleAnalytics.astro
Commented out PUBLIC_GA_MEASUREMENT_ID environment variable passing in E2E-Tests and Visual-Regression-Tests jobs; removed ts-expect-error suppression comment from fetchpriority attribute in GoogleAnalytics component

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A comment removed, some lines tucked away,
Google's measurement takes a quiet day,
TypeScript sighs—no more expect-error cries,
Simpler code beneath the digital skies!


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ec34aa and 5a09cd2.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • src/components/GoogleAnalytics.astro

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@area73 area73 merged commit fb37f90 into master Jan 6, 2026
6 of 8 checks passed
@area73 area73 deleted the env-var-ga branch January 6, 2026 19:49
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 16

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

HOST: 0.0.0.0
BASE_URL: http://127.0.0.1:4321
PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
# PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual-Regression-Tests will always fail due to validation check

High Severity

The PUBLIC_GA_MEASUREMENT_ID environment variable is commented out at line 88, but lines 97-103 still contain a validation step that checks if this variable is set and exits with error code 1 if empty. Since the variable is no longer set, the validation will always fail, causing the Visual-Regression-Tests job to fail every time it runs.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants