Skip to content

New dependency plugin design #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TimMurphy wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

New dependency plugin design #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d4539c
Remove two build messages
TimMurphy Dec 5, 2025
82e46f7
Improve debugging
TimMurphy Dec 6, 2025
26071f8
Update plugin list in RuntimePluginLocatorTests
TimMurphy Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Tests/Reqnroll.PluginTests/RuntimePluginLocatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,17 @@ public void LoadPlugins_Find_All_Referenced_Plugins()
var allProjectReferenceFoundByPluginLocator = projectReferences.All(pr => plugins.Any(plugin => plugin.Contains(pr)));
allProjectReferenceFoundByPluginLocator.Should().BeTrue();

var foundPlugins = plugins.Select(Path.GetFileName);
var foundPlugins = plugins.Select(Path.GetFileName).OrderBy(p => p);
foundPlugins.Should().BeEquivalentTo([
"Reqnroll.PluginTests.dll", // This test assembly
"Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin.dll",
"Reqnroll.Autofac.ReqnrollPlugin.dll",
"Reqnroll.ExternalData.ReqnrollPlugin.dll",
"Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin.dll",
"Reqnroll.MSTest.Generator.ReqnrollPlugin.dll",
"Reqnroll.MSTest.ReqnrollPlugin.dll",
"Reqnroll.NUnit.Generator.ReqnrollPlugin.dll",
"Reqnroll.NUnit.ReqnrollPlugin.dll",
"Reqnroll.PluginTests.dll", // This test assembly
"Reqnroll.Windsor.ReqnrollPlugin.dll",
"Reqnroll.MSTest.ReqnrollPlugin.dll",
"Reqnroll.NUnit.ReqnrollPlugin.dll",
"Reqnroll.xUnit.ReqnrollPlugin.dll",
"Reqnroll.xUnit.Generator.ReqnrollPlugin.dll",
]);
Expand Down
7 changes: 2 additions & 5 deletions Tests/Reqnroll.RuntimeTests/Formatters/FormatterBaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,18 @@ namespace Reqnroll.RuntimeTests.Formatters;

public class FormatterBaseTests
{
private class TestFormatter : FormatterBase
private class TestFormatter(IFormattersConfigurationProvider config, IFormatterLog logger, string name) : FormatterBase(config, logger, name)
{
public bool LaunchInnerCalled = false;
public IDictionary<string, object> LaunchInnerConfig = null!;
public Action<bool> LaunchInnerCallback = null!;
public bool ConsumeAndFormatMessagesCalled = false;
public CancellationToken? ConsumedToken;
public List<Envelope> ConsumedMessages = new();
public List<Envelope> ConsumedMessages = [];
public bool ReportInitializedCalled = false;
public bool CloseAsyncCalled = false;
public bool CompleteWriterOnLaunchInner = false;

public TestFormatter(IFormattersConfigurationProvider config, IFormatterLog logger, string name)
: base(config, logger, name) { }

public override void LaunchInner(IDictionary<string, object> formatterConfig, Action<bool> onAfterInitialization)
{
LaunchInnerCalled = true;
Expand Down
Loading