Change read visibility of PickleId property to public.#1050
Change read visibility of PickleId property to public.#1050clrudolphi wants to merge 2 commits intomainfrom
Conversation
Agree. If we like to see some API backwards compatiblility tests, just let me know. |
Reqnroll/ScenarioInfo.cs
Outdated
| /// This holds the unique identifier for the test ("pickle") represented by this scenario info. Used internally at runtime. | ||
| /// </summary> | ||
| internal string PickleId { get; set; } | ||
| public string PickleId { get; set; } |
There was a problem hiding this comment.
I havent read the full discussion. But is also a public setter needed?
|
No. I should change that to public get, internal set
Chris
________________________________
From: Julian Verdurmen ***@***.***>
Sent: Thursday, February 26, 2026 10:11:03 AM
To: reqnroll/Reqnroll ***@***.***>
Cc: Chris Rudolphi ***@***.***>; Author ***@***.***>
Subject: Re: [reqnroll/Reqnroll] Change visibility of PickleId property to public. (PR #1050)
@304NotModified commented on this pull request.
________________________________
In Reqnroll/ScenarioInfo.cs<#1050 (comment)>:
@@ -49,7 +49,7 @@ public class ScenarioInfo
/// <summary>
/// This holds the unique identifier for the test ("pickle") represented by this scenario info. Used internally at runtime.
/// </summary>
- internal string PickleId { get; set; }
+ public string PickleId { get; set; }
I havent read the full discussion. But is also a public setter needed?
—
Reply to this email directly, view it on GitHub<#1050 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAM7YMVWHPGC5NQGGYPMEMT4N4LJPAVCNFSM6AAAAACWAVH36GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNRSGAYDEMJQGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
|
||
| ## Bug fixes: | ||
| * Fix: Formatters incorrectly handle Unicode text file content of attachments. | ||
| * Enhancement: Changed visibility of PickleId property of ScenarioInfo to public. |
There was a problem hiding this comment.
I think this should be under Improvements by the way. (And maybe mention "read")
|
I am generally fine with this enhancement. But before we merge, let me just raise my concerns. Maybe I'm a bit confused. Two problems:
|
Good points. Let me look into this further. There is a testCaseId, and it might be a more suitable id to use as it would be unique per pickle execution (aka unique per retry). In terms of where to surface runtime information, you prefer that it be in the Scenario Context right? |
|
I realize, now, that this approach has the distinct disadvantage that it won't work for those solutions which are not using Formatters. The PickleId is populated by one of the execution event handlers of the Formatters sub-system. |
🤔 What's changed?
Change visibility of PickleId property to public.
⚡️ What's your motivation?
See discussion #1049
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I don't see a need to add tests for this simple change.
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.