Skip to content

Fix Formatter handling of unicode text in embedded attachments#1041

Merged
gasparnagy merged 2 commits intomainfrom
Fix_1035_attachmentEncodingHandling
Feb 20, 2026
Merged

Fix Formatter handling of unicode text in embedded attachments#1041
gasparnagy merged 2 commits intomainfrom
Fix_1035_attachmentEncodingHandling

Conversation

@clrudolphi
Copy link
Contributor

@clrudolphi clrudolphi commented Feb 18, 2026

🤔 What's changed?

Improved the Formatters handling of text attachments when the text includes unicode characters.

⚡️ What's your motivation?

Properly handle/display reports.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@304NotModified
Copy link
Member

Thanks! I think this really needs an unit test to prevent breaking it in the future (:

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Cool. You should have spent some time to find this issue. Thx for your efforts!

@gasparnagy gasparnagy merged commit ce51c09 into main Feb 20, 2026
8 checks passed
@gasparnagy gasparnagy deleted the Fix_1035_attachmentEncodingHandling branch February 20, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants