Skip to content

Try fixing connector for AspNetAndMSDI#156

Merged
gasparnagy merged 9 commits intomainfrom
fix-connector-for-VsExtConnectorTestSamples.AspNetAndMSDI
Jan 28, 2026
Merged

Try fixing connector for AspNetAndMSDI#156
gasparnagy merged 9 commits intomainfrom
fix-connector-for-VsExtConnectorTestSamples.AspNetAndMSDI

Conversation

@gasparnagy
Copy link
Contributor

@gasparnagy gasparnagy commented Jan 21, 2026

🤔 What's changed?

Changed connector to load Microsoft.Extensions.DependencyInjection.Abstractions from NuGet cache based on the repro of @Obelixx.

⚡️ What's your motivation?

Fix the issue of @Obelixx. Issue number ???.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Wonder what else we make wrong with this 😎...

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@gasparnagy
Copy link
Contributor Author

So that single test is passing now, but all others fail... 😎

@gasparnagy
Copy link
Contributor Author

@Obelixx Do you have a change to check if the problem resolves with the VSIX from this PR?

@Obelixx
Copy link

Obelixx commented Jan 21, 2026

@Obelixx Do you have a change to check if the problem resolves with the VSIX from this PR?

I will - tomorrow or Sunday.

@Obelixx
Copy link

Obelixx commented Jan 24, 2026

@gasparnagy
Tested on the reproduction project with the VSIX from this PR. Navigation works.

On the work project it seems we have removed some dependencies and I no longer have an issue with navigation (with current version). I had to rollback some commits, clean project, restart VS and build again to get back the exception in Reqnroll output window. After installing local version from the PR (and rebuild) - the exception is gone and navigation works again.
🥳

@gasparnagy
Copy link
Contributor Author

On the work project it seems we have removed some dependencies and I no longer have an issue with navigation (with current version). I had to rollback some commits, clean project, restart VS and build again to get back the exception in Reqnroll output window. After installing local version from the PR (and rebuild) - the exception is gone and navigation works again. 🥳

Super, thx for the feedback!

# Conflicts:
#	Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.slnx
@gasparnagy gasparnagy marked this pull request as ready for review January 27, 2026 20:09
@gasparnagy gasparnagy requested a review from clrudolphi January 27, 2026 20:09
Copy link
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gasparnagy gasparnagy merged commit a3572a1 into main Jan 28, 2026
4 checks passed
@gasparnagy gasparnagy deleted the fix-connector-for-VsExtConnectorTestSamples.AspNetAndMSDI branch January 28, 2026 10:32
@gasparnagy
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants