Merged
Conversation
clrudolphi
reviewed
Aug 23, 2025
Contributor
|
Well, temporarily dead. The intent is that we'll add xunit back to the view model.
Chris
________________________________
From: Julian Verdurmen ***@***.***>
Sent: Saturday, August 23, 2025 5:06:58 PM
To: reqnroll/Reqnroll.VisualStudio ***@***.***>
Cc: Chris Rudolphi ***@***.***>; Review requested ***@***.***>
Subject: Re: [reqnroll/Reqnroll.VisualStudio] Remove xunit3 (for now) (PR #118)
@304NotModified commented on this pull request.
________________________________
In Reqnroll.VisualStudio.ProjectTemplate/ProjectTemplate.csproj<#118 (comment)>:
@@ -10,9 +10,6 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />$if$ ('$unittestframework$' == 'xUnit')
<PackageReference Include="Reqnroll.xUnit" Version="3.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
- <PackageReference Include="xunit.runner.visualstudio" Version="3.1.3" />$endif$$if$ ('$unittestframework$' == 'xUnit3')
because of the change in Reqnroll.VisualStudio/UI/ViewModels/AddNewReqnrollProjectViewModel.cs?
We could leave it, but then it's dead code and that is always confusing ;)
—
Reply to this email directly, view it on GitHub<#118 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAM7YMULQANXWKG23KIAAX33PDQYFAVCNFSM6AAAAACEUTAN6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNBYHE2TIMBVGI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
clrudolphi
approved these changes
Aug 24, 2025
Contributor
clrudolphi
left a comment
clrudolphi
left a comment
There was a problem hiding this comment.
Sorry about that; your suggestion is quite reasonable.
304NotModified
added a commit
that referenced
this pull request
Aug 25, 2025
This reverts commit 581ccd8.
Member
Author
|
merged and create PR to introduce again when xunit3 has been merged => #120 |
gasparnagy
added a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Remove xunit3 (for now) (#118)" This reverts commit 581ccd8. * Corrected template so that $if$ statement matches properly when xunit.v3 is selected. Updated Reqnroll plugin references to v3.1.0 * Updated ChangeLog added #120 to the Improvement list * use 3.2.0 in project template --------- Co-authored-by: Chris Rudolphi <1702962+clrudolphi@users.noreply.github.com> Co-authored-by: Gáspár Nagy <gaspar.nagy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Removed xunit3 for now
⚡️ What's your motivation?
reqnroll/Reqnroll#538 hasn't merged yet and I think we should release a new version of this plugin before the release of the xUnit 3 support.
When reqnroll/Reqnroll#538 is merged and released, then we could revert this PR :)
🏷️ What kind of change is this?