Add BaB newsletter #1325
Add BaB newsletter #1325
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
annatraussnig
left a comment
annatraussnig
left a comment
There was a problem hiding this comment.
I am left scratching my head a bit, mostly regarding the inner working of our tests and the absence of an ALL_OUR_NEWSLETTERS array somewhere, which we could refer too when doing similar operations on all our newsletters.
Neither of which is your fault or your responsibility.
| 'MAILCHIMP_INTEREST_NEWSLETTER_CLIMATE', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_WDWWW: 'MAILCHIMP_INTEREST_NEWSLETTER_WDWWW', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_SUNDAY: 'MAILCHIMP_INTEREST_NEWSLETTER_SUNDAY', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_BAB: 'MAILCHIMP_INTEREST_NEWSLETTER_BAB', |
There was a problem hiding this comment.
do we need aaaaall the newsletters in a test?
There was a problem hiding this comment.
the real question is: why are newsletter subscriptions tracked as consents 🥲
| 'MAILCHIMP_INTEREST_NEWSLETTER_CLIMATE', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_WDWWW: 'MAILCHIMP_INTEREST_NEWSLETTER_WDWWW', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_SUNDAY: 'MAILCHIMP_INTEREST_NEWSLETTER_SUNDAY', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_BAB: 'MAILCHIMP_INTEREST_NEWSLETTER_BAB', |
There was a problem hiding this comment.
do we need aaaaall the newsletters in a test?
| 'NEWSLETTER_PROJECTR', | ||
| 'NEWSLETTER_WDWWW', | ||
| 'NEWSLETTER_SUNDAY', | ||
| 'NEWSLETTER_BAB', |
There was a problem hiding this comment.
would refactor into having a standalone NEWSLETTERS_POLICIES array, which we merge in. small change, but still
There was a problem hiding this comment.
I don't understand why we need one template per NL type.
| 'MAILCHIMP_INTEREST_NEWSLETTER_CLIMATE', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_WDWWW: 'MAILCHIMP_INTEREST_NEWSLETTER_WDWWW', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_SUNDAY: 'MAILCHIMP_INTEREST_NEWSLETTER_SUNDAY', | ||
| MAILCHIMP_INTEREST_NEWSLETTER_BAB: 'MAILCHIMP_INTEREST_NEWSLETTER_BAB', |
There was a problem hiding this comment.
re-tests. i feel like a good test should check the mechanism by which we do xxx. This doesn't make any sense to me (obv not for you to fix now).
|
Thanks for the review, we actually agree on all the points 😅 I'll look into maybe improving some of the things because we'll soon be adding another NL, and it would actually be nice to have a (slightly) improved setup process, maybe. |
Adds all the bits and pieces necessary for turning BaB into a newsletter format. In addition to these code changes, make sure to:
"newsletter": { "free": true, "name": "BAB" }, "sendAsEmail": true,Testing: