remove allowedRoles from discussions #1311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-31
to
-32
| Roles.ensureUserIsInRoles(me, discussion.allowedRoles) | ||
|
|
Contributor
There was a problem hiding this comment.
how come we are not checking for membership here?
Contributor
Author
There was a problem hiding this comment.
Line 42 already has userCanComment(discussion, null, context), which checks that. This is redundant.
Comment on lines
35
to
51
| if ( | ||
| (settings.title && settings.title !== discussion.title) || | ||
| (settings.maxLength && settings.maxLength !== discussion.maxLength) || | ||
| (settings.anonymity && settings.anonymity !== discussion.anonymity) || | ||
| (settings.path && settings.path !== discussion.path) || | ||
| (settings.closed !== undefined && | ||
| settings.closed !== null && | ||
| settings.closed !== discussion.closed) || | ||
| (settings.collapsable !== undefined && | ||
| settings.collapsable !== null && | ||
| settings.collapsable !== discussion.collapsable) || | ||
| (settings.tagRequired !== undefined && | ||
| settings.tagRequired !== discussion.tagRequired) || | ||
| (settings.tags && settings.tags !== (discussion.tags || []).join(',')) || | ||
| (settings.allowedRoles && | ||
| settings.allowedRoles !== (discussion.allowedRoles || []).join(',')) || | ||
| (!discussion.repoId && id && !idIsUUID && legacyDiscussionId) // to save repoId to existing discussions |
Contributor
There was a problem hiding this comment.
my eyes!! my eyes!! (not your fault, i know, but still, can any human read this?)
annatraussnig
approved these changes
Dec 17, 2025
Contributor
annatraussnig
left a comment
annatraussnig
left a comment
There was a problem hiding this comment.
Changes look reasonable, but we should test the changes before deploy (i haven't).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remnant of klimalabor.