Skip to content

EPMRPP-104956 editor can drag drop selected folder - fixes styles#249

Merged
kayarmolenka merged 2 commits intodevelopfrom
feature/EPMRPP-104956-editor-can-drag-drop-selected-folder-fixes-styles
Mar 2, 2026
Merged

EPMRPP-104956 editor can drag drop selected folder - fixes styles#249
kayarmolenka merged 2 commits intodevelopfrom
feature/EPMRPP-104956-editor-can-drag-drop-selected-folder-fixes-styles

Conversation

@kayarmolenka
Copy link
Contributor

@kayarmolenka kayarmolenka commented Mar 2, 2026

Summary by CodeRabbit

  • New Features

    • Added support for "inside" drop positioning in sortable tree components with improved visual feedback.
  • Style

    • Enhanced drop confirmation UI with clearer positioning and styling for drag-and-drop indicators.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4aa224 and a8e91e1.

📒 Files selected for processing (3)
  • src/components/sortable/treeSortableContainer/treeSortableContainer.module.scss
  • src/components/sortable/treeSortableContainer/treeSortableContainer.tsx
  • src/components/sortable/treeSortableItem/treeSortableItem.module.scss

Walkthrough

The changes extend the tree sortable drag-and-drop component to support an "inside" drop position variant. Updates include: importing TREE_DROP_POSITIONS constants, refactoring position handling from string literals to typed constants, adding styling for the inside position with adjusted popover placement, and updating hover button colors.

Changes

Cohort / File(s) Summary
Tree Sortable Container Styles
src/components/sortable/treeSortableContainer/treeSortableContainer.module.scss
Adds inside variant styling for drop-confirmation-popover with adjusted transform and positioning; updates ::after pseudo-element arrow placement with left centering; changes popover button hover color from primary to neutral background.
Tree Sortable Container Logic
src/components/sortable/treeSortableContainer/treeSortableContainer.tsx
Imports TREE_DROP_POSITIONS constant; introduces POPOVER_OFFSET_PX and extends DEFAULT_LABELS; refactors position calculations and CSS class toggling to use typed position constants instead of string literals; adds INSIDE state handling.
Tree Sortable Item Styles
src/components/sortable/treeSortableItem/treeSortableItem.module.scss
Adds background-color to drop-inside drop target pseudo-element for improved visual feedback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • AmsterGet
  • allaprischepa
  • maria-hambardzumian
  • siarheirazuvalau

Poem

🐰 A popover hops inside with grace,
Constants guide each drop in place,
Inside, before, and after too,
Three positions, styling new,
The tree keeps bouncing, neat and sweet! 🌳✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change - it addresses drag-drop functionality for selected folders and specifically mentions style fixes, which aligns with the CSS modifications and positioning logic updates in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/EPMRPP-104956-editor-can-drag-drop-selected-folder-fixes-styles

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayarmolenka kayarmolenka merged commit 622a172 into develop Mar 2, 2026
2 checks passed
@kayarmolenka kayarmolenka deleted the feature/EPMRPP-104956-editor-can-drag-drop-selected-folder-fixes-styles branch March 2, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants