-
Notifications
You must be signed in to change notification settings - Fork 105
Restore rp_display_suite_test_file and fix bug with rp_dir_level #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore rp_display_suite_test_file and fix bug with rp_dir_level #383
Conversation
|
Hello @HardNorth , will be great if you could take a look and review this. If that's fine, it will be great to have a new release with this change. thanks! |
|
Hi @HardNorth, anything I can do to promote this PR? thanks you! |
HardNorth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramir-dn, Thanks for the suggestion, but looks like you checked out broken code which was in develop branch for one day. Please pull the latest changes.
|
Thanks @HardNorth , updated my branch. Can you test again please? |
|
@HardNorth , I fixed the missing parameter. I am not sure what happened in my local tox run but it didn't detect it. Can you please rerun? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
- Coverage 68.35% 68.22% -0.13%
===========================================
Files 6 6
Lines 970 982 +12
===========================================
+ Hits 663 670 +7
- Misses 307 312 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HardNorth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @HardNorth! |
|
@ramir-dn Please wait for a day or two. I have to rework your code and add tests. |
|
@ramir-dn Please use this version: https://github.com/reportportal/agent-python-pytest/releases/tag/5.4.6 |
|
That was quick! Thanks @HardNorth! |
Hellow,
This PR handles 2 things:
rp_dir_level: in_remove_root_dirs, the loop that handles the ROOT node only handled it first child and calledreturn.rp_display_suite_test_file. It depends onrp_dir_levelin a way that if the file name appears deep in the hierarchy, it will be kept and not deleted. The default isTrueto keep the current behavior, but if set toFalse, and therp_dir_levelis deep enough, the file name will be removed too, and will be left with suites and tests only in the hierarchy.