forked from 2600hz/kazoo
-
Notifications
You must be signed in to change notification settings - Fork 1
Master acdc #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noahmehl
wants to merge
13
commits into
master
Choose a base branch
from
master-acdc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master acdc #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some fixes highlighted by circleci testing more codechecks fix dialyzer issues more dialyze errors remove unused process_trap fix max_queue_size checking for unstaged files, again more circle fixes
some fixes highlighted by circleci testing more codechecks fix dialyzer issues more dialyze errors remove unused process_trap fix max_queue_size checking for unstaged files, again more circle fixes
1) Convert FSMs from gen_fsm to gen_statem
2) remove playback_stop dependency
3) manually merge Daniel's 4.3 PRs
List of Daniel's PRs merged:
Description Commit Id kageds/master-acdc
status
-----------------------------------------------------------------------------------------------------
Actually set last_connect in acdc_agent_listener 1ad1933 already present
PISTON-188: update agent_listener queue id during originate, no 81d70b4 already present
PISTON-371: handle ringing cancellations better when originate_ 662a76c already present
PISTON-55: acdc distributed member_connect_win (#6 51ac54a OK
PISTON-315: correctly identify endpoint id during load_endpoint dbbb411 already present
PISTON-375: add dedicated force-restart API for acdc (# 9cead8a OK
[4.3] PISTON-772: do not start agents in acdc_queue_manager 9eb224e OK
[4.3] Check if ErrJObj is actually a JObj (2600hz#6563) 0b5a29a already present
[4.3] PISTON-183: acdc_agent_fsm state sync using shared events bf8ea2d already present
[4.3] PISTON-397: handle agent channels that are destroyed qui d4afa8f already present
PISTON-893: acdc_agent_listener doesn't need route.req, don't b fe86855 OK
PISTON-290: refactor transfer tracking in acdc agent (# 26a67cc already present
acdc_agent_fsm: don't set ready status until apply_state_update 21769cc already present
PISTON-371: missed change in paused state 'originate_uuid' ( eb53a39 already present
PISTON-592: clear call state when ending wrapup early (# 475c729 already present
PISTON-976: significant performance improvements for acdc statu f22e119 needs work
PISTON-625: do not pass pids as start_link args (#6 9bd3339 OK
[4.3] PISTON-234: keep modified caller ID on phone after bridge cb9a8c8 already present
[4.3] PISTON-352: track endpoints in acdc_agent_fsm better ( 4dc25e7 already present
[4.3] Misc sync-up changes to acdc (2600hz#6575) a028dd8 already present
[4.3] PISTON-773: rework some acdc_agent_util status code ( d7497f2 needs work
[4.3] PISTON-116: acdc_agent_fsm: stop ringing when pausing 6e80559 already present
[4.3] remove unused acdc_agent_listener:maybe_update_presence_s 1914499 OK
[4.3] PISTON-1083: acdc stats: allow some wiggle room on query ee3382d OK
[4.3] acdc ignore/cancel/exit overhaul (2600hz#6588) 08115c9 already present
[4.3] Fix number of tuple elements to acdc_queue_manager's agen dcfed9f already present
[4.3] Many dialyzer fixes for acdc (2600hz#6590) 542e518 OK
[4.3] Support infinity for agent pause time (2600hz#65 38ac480 OK
[4.3] PISTON-292: support for pause aliases (2600hz#65 dfa6cb3 OK
NOTE: The 2 PRs identiified as "needs work" are related to ETS improvements and require further study as some ETS tables maybe moved
to a distrubted mnesia table in order to have a cluster view rather than a node view.
Author
|
Need to add the missing prompts to kazoo-media repo. |
1) Convert FSMs from gen_fsm to gen_statem
2) remove playback_stop dependency
3) manually merge Daniel's 4.3 PRs
List of Daniel's PRs merged:
Description Commit Id kageds/master-acdc
status
-----------------------------------------------------------------------------------------------------
Actually set last_connect in acdc_agent_listener 1ad1933 already present
PISTON-188: update agent_listener queue id during originate, no 81d70b4 already present
PISTON-371: handle ringing cancellations better when originate_ 662a76c already present
PISTON-55: acdc distributed member_connect_win (#6 51ac54a OK
PISTON-315: correctly identify endpoint id during load_endpoint dbbb411 already present
PISTON-375: add dedicated force-restart API for acdc (# 9cead8a OK
[4.3] PISTON-772: do not start agents in acdc_queue_manager 9eb224e OK
[4.3] Check if ErrJObj is actually a JObj (2600hz#6563) 0b5a29a already present
[4.3] PISTON-183: acdc_agent_fsm state sync using shared events bf8ea2d already present
[4.3] PISTON-397: handle agent channels that are destroyed qui d4afa8f already present
PISTON-893: acdc_agent_listener doesn't need route.req, don't b fe86855 OK
PISTON-290: refactor transfer tracking in acdc agent (# 26a67cc already present
acdc_agent_fsm: don't set ready status until apply_state_update 21769cc already present
PISTON-371: missed change in paused state 'originate_uuid' ( eb53a39 already present
PISTON-592: clear call state when ending wrapup early (# 475c729 already present
PISTON-976: significant performance improvements for acdc statu f22e119 needs work
PISTON-625: do not pass pids as start_link args (#6 9bd3339 OK
[4.3] PISTON-234: keep modified caller ID on phone after bridge cb9a8c8 already present
[4.3] PISTON-352: track endpoints in acdc_agent_fsm better ( 4dc25e7 already present
[4.3] Misc sync-up changes to acdc (2600hz#6575) a028dd8 already present
[4.3] PISTON-773: rework some acdc_agent_util status code ( d7497f2 needs work
[4.3] PISTON-116: acdc_agent_fsm: stop ringing when pausing 6e80559 already present
[4.3] remove unused acdc_agent_listener:maybe_update_presence_s 1914499 OK
[4.3] PISTON-1083: acdc stats: allow some wiggle room on query ee3382d OK
[4.3] acdc ignore/cancel/exit overhaul (2600hz#6588) 08115c9 already present
[4.3] Fix number of tuple elements to acdc_queue_manager's agen dcfed9f already present
[4.3] Many dialyzer fixes for acdc (2600hz#6590) 542e518 OK
[4.3] Support infinity for agent pause time (2600hz#65 38ac480 OK
[4.3] PISTON-292: support for pause aliases (2600hz#65 dfa6cb3 OK
NOTE: The 2 PRs identiified as "needs work" are related to ETS improvements and require further study as some ETS tables maybe moved
to a distrubted mnesia table in order to have a cluster view rather than a node view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working PR for updates to ACDC for stability and features.