Issue #457: Move SAVEPOINT outside the retry loop and call RELEASE SAVEPOINT #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
za-arthur
force-pushed
the
issue_457_savepoint
branch
2 times, most recently
from
4642975 to
60018f7
Compare
…VEPOINT lock_access_share() and lock_exclusive() doesn't call RELEASE SAVEPOINT on every retry which pollutes the cache and degrades the performance. This commit calls RELEASE SAVEPOINT when created savepoint is not necessary anymore. Additionally it moves SAVEPOINT outside of the retry loop since it isn't necessary to create new savepoint on every retry at all. lock_exclusive() also moves start of transaction outside of the retry loop and creates a savepoint regardless of the value start_xact.
To be able to build pg_repack with Postgres 18 we need to install libnuma-dev: postgres/postgres@65c298f
za-arthur
force-pushed
the
issue_457_savepoint
branch
from
60018f7 to
b407e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lock_access_share()andlock_exclusive()doesn't call RELEASE SAVEPOINT on every retry which pollutes the cache and degrades the performance. This commit calls RELEASE SAVEPOINT when created savepoint is not necessary anymore. Additionally it moves SAVEPOINT outside of the retry loop since it isn't necessary to create new savepoint on every retry at all.lock_exclusive()also moves start of transaction outside of the retry loop and creates a savepoint regardless of the valuestart_xact.Now Github workflow also installs
libnuma-devfor PostgreSQL 18 since it has new option--with-libnuma:https://www.postgresql.org/docs/18/release-18.html
Issue #457