Issue #420: Acquire SHARE UPDATE EXCLUSIVE by conn2 #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently conn2 acquires ACCESS SHARE lock which allows to run concurrent DDL statements, like CREATE INDEX CONCURRENTLY. Fix it by acquiring SHARE UPDATE EXCLUSIVE lock. This will also lock concurrent VACUUM, ANALYZE queries, locking them looks safer option anyway.
Collaborator
|
Makes sense. |
farrokhi
pushed a commit
to farrokhi/pg_repack
that referenced
this pull request
Nov 5, 2025
Currently conn2 acquires ACCESS SHARE lock which allows to run concurrent DDL statements, like CREATE INDEX CONCURRENTLY. Fix it by acquiring SHARE UPDATE EXCLUSIVE lock. This will also lock concurrent VACUUM, ANALYZE queries, locking them looks safer option anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently conn2 acquires
ACCESS SHARElock which allows to run concurrent DDL statements, likeCREATE INDEX CONCURRENTLY.Fix it by acquiring
SHARE UPDATE EXCLUSIVElock. This will also lock concurrentVACUUM,ANALYZEqueries, locking them looks safer option anyway.Thoughts?
Issue #420