Fixed issue where profiles were changing operation type on save #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue renyuneyun#409 - Profiles created with "Send Broadcast" or "Start Service" operation type revert to "Start Activity" on save. This was occurring because all intent profiles used the IntentOperationData data type and LocalSkillRegistry used this data type to match the profile with a skill. All intent profiles would match against all intent skills, so the first intent skill in the list (which was ActivityOperationSkill) would always be assigned to every intent data type. To fix this issue, new data types were created for all the intent operation skills. Associated DataFactory and SkillViewFragment classes were created as well. The IntentOperationDataTest was also updated. A intent operation utility class was created to house some shared code.
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #409 - Profiles created with "Send Broadcast" or "Start Service" operation type revert to "Start Activity" on save. This was occurring because all intent profiles used the IntentOperationData data type and LocalSkillRegistry used this data type to match the profile with a skill. All intent profiles would match against all intent skills, so the first intent skill in the list (which was ActivityOperationSkill) would always be assigned to every intent data type. To fix this issue, new data types were created for all the intent operation skills. Associated DataFactory and SkillViewFragment classes were created as well. The IntentOperationDataTest was also updated. A intent operation utility class was created to house some shared code.