feat: new args system #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 CLI Preview Build.Try this version: bun add -g https://pkg.pr.new/renejfc/conmmit@7v1 — 65c13b0 |
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/main.ts:47
- [nitpick] The flag 'add-all' is accessed using bracket notation due to its hyphenated name. Consider using an alias (e.g., 'addAll') in the configuration to allow a more consistent dot notation access across the codebase.
enabled: args["add-all"],
| const SHORT_PREFIX = "-" | ||
| export function parseArgs<const T extends ArgConfig[]>(argConfigs: T): ParsedArgs<T> { | ||
| const argv = process.argv.slice(2) | ||
| console.log(argv) |
There was a problem hiding this comment.
Debug logging is present in the production argument parsing code. It is recommended to remove or disable this log before deployment to prevent leaking internal information.
Suggested change
| console.log(argv) |
|
|
||
| export const initArgs = () => { | ||
| const args = parseArgs(argsConfigs) | ||
| console.log(args) |
There was a problem hiding this comment.
A console log statement remains in the initArgs function, which might be unintended for production usage. Consider removing it to clean up the output.
Suggested change
| console.log(args) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.