Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ impl MatchingEngineExecutor {
},
Err(e) => {
error!("internal match settlement failed for {} x {}: {e}", other_id, order_id,);

// Check whether matching should continue
if !self.order_still_valid(&order_id).await? {
info!("account has changed, stopping internal matching engine...");
return Ok(());
}
},
}

Expand Down Expand Up @@ -153,20 +147,6 @@ impl MatchingEngineExecutor {
})
}

/// TODO: Update this comment when we re-implement
/// Check whether a wallet is still valid. This amounts to checking:
/// 1. Whether the wallet's known nullifier is still valid. This may be
/// false if the wallet has been updated since a match was attempted
/// 2. Whether the wallet's queue is still empty and unpaused.
/// Concurrent matches from elsewhere in the relayer may cause this
/// second condition to be false
///
/// This check may be executed after a match settlement fails
async fn order_still_valid(&self, order_id: &OrderId) -> Result<bool, MatchingEngineError> {
warn!("Re-implement order still valid check");
Ok(true)
}

/// Fetch the privacy ring for an order
async fn get_order_ring(&self, order_id: &OrderId) -> Result<PrivacyRing, MatchingEngineError> {
self.state.get_order_ring(order_id).await?.ok_or_else(|| {
Expand Down
Loading