Skip to content

Conversation

@rencevio
Copy link
Owner

@rencevio rencevio commented Nov 29, 2020

Nice-to-haves/concerns:

  • All photos are fetched with the fixed size (800px-longest for preview and 1024px-longest for the full size) regardless of the user's screen size
  • When switching to the landscape orientation on iPad, some constraint errors are logged, though the app is rendered correctly
  • For the full image view, the large size (1024px-longest) of the photo is displayed. That might not be the original size, but any size beyond the large required user authentication
  • When image data for a collection of photos is requested, only photos with successfully fetched data are returned; the rest are ignored. This is not an ideal error handling but is suitable for the MVP
  • It is not possible to show the load progress of a full-size photo download, as Flickr API does not provide the Content-Length header
  • Scroll animation when the user has scrolled down to the bottom of the feed is a little bit wonky sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants