Skip to content

Fix Slashes and CreateReadOnlyShare #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cinerar wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Slashes and CreateReadOnlyShare #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a485411
fix backslash character as path separator when run on windows
Cinerar Jun 15, 2020
567e7ff
fix all filepath.join when run on windows
Cinerar Jun 15, 2020
d65f6af
CreateReadOnlyShare
Cinerar Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (c *Client) UploadDir(src string, dest string) ([]string, error) {
if err != nil {
return nil, err
}
err = c.Upload(data, filepath.Join(dest, filepath.Base(file)))
err = c.Upload(data, filepath.ToSlash(filepath.Join(dest, filepath.Base(file))))
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -147,7 +147,7 @@ func (c *Client) CreateFileDropShare(path string) (*ShareResult, error) {
}

func (c *Client) CreateReadOnlyShare(path string) (*ShareResult, error) {
result, err := c.CreateShare(path, 3, "true", 4)
result, err := c.CreateShare(path, 3, "false", 4)
if err != nil {
return nil, err
}
Expand All @@ -158,8 +158,7 @@ func (c *Client) CreateReadOnlyShare(path string) (*ShareResult, error) {
func (c *Client) sendWebDavRequest(request string, path string, data []byte) ([]byte, error) {
// Create the https request

webdavPath := filepath.Join("remote.php/webdav", path)

webdavPath := filepath.ToSlash(filepath.Join("remote.php/webdav", path))
folderUrl, err := url.Parse(webdavPath)
if err != nil {
return nil, err
Expand Down Expand Up @@ -203,7 +202,7 @@ func (c *Client) sendWebDavRequest(request string, path string, data []byte) ([]
func (c *Client) sendAppsRequest(request string, path string, data string) (*ShareResult, error) {
// Create the https request

appsPath := filepath.Join("apps", path)
appsPath := filepath.ToSlash(filepath.Join("apps", path))

folderUrl, err := url.Parse(appsPath)
if err != nil {
Expand Down Expand Up @@ -246,7 +245,7 @@ func (c *Client) sendAppsRequest(request string, path string, data string) (*Sha
func (c *Client) sendOCSRequest(request string, path string, data string) (*ShareResult, error) {
// Create the https request

appsPath := filepath.Join("ocs/v2.php/apps/files_sharing/api/v1", path)
appsPath := filepath.ToSlash(filepath.Join("ocs/v2.php/apps/files_sharing/api/v1", path))

folderUrl, err := url.Parse(appsPath)
if err != nil {
Expand Down