ModalActionSheet to be displayed anywhere in component tree#3
Open
faceyspacey wants to merge 4 commits intoremobile:masterfrom
Open
ModalActionSheet to be displayed anywhere in component tree#3faceyspacey wants to merge 4 commits intoremobile:masterfrom
faceyspacey wants to merge 4 commits intoremobile:masterfrom
Conversation
…t tree The idea behind this thin wrapper is that it allows you to put action sheet's anywhere in your component tree, not just in a component that consumes the entire screen. It's supposed to be a drop-in replacement for plain ActionSheet.
the modal was cutting the slide-down animation short. so now they are synced so that the action sheet slides down, and then the modal hides itself. A bit of hackery was necessary as the `onDismiss` callback of `Modal` isn't working in RN22. perhaps the `onRequestClose` callback `Modal` has in RN23 will come to the rescue, but it I did manually via `setTimeout` for now to guarantee it works across RN versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea behind this thin wrapper is that it allows you to put action sheet's anywhere in your component tree, not just in a component that consumes the entire screen. It's supposed to be a drop-in replacement for plain ActionSheet. I think this is the way most people expect to use the action sheet by the way--i.e. as a modal.