This repository was archived by the owner on Sep 3, 2025. It is now read-only.
assignment 1 improved to reach excellent in rubric#3
Merged
github-bowen merged 14 commits intomainfrom Jun 8, 2025
Merged
Conversation
…model-service into assignment1-improvements
kanta8864
requested review from
cactusutcac,
github-bowen,
raghavtalwar7 and
zeri27
Member
There was a problem hiding this comment.
Could you add a tag to your latest commit on this branch to activate the github workflow and check if there's any error?
Member
There was a problem hiding this comment.
Except the above item, everything else looks good!
Contributor
Author
There was a problem hiding this comment.
Yes will do in a bit.
…model-service into assignment1-improvements
github-bowen
approved these changes
May 30, 2025
Member
github-bowen
left a comment
github-bowen
left a comment
There was a problem hiding this comment.
[Trivial/Optional] Seems that "commit README update" stage in workflow.yml exited with error, but the output details shows no error. Might need to change the checking condition of this step.
Otherwise no problems
github-bowen
suggested changes
May 30, 2025
Member
github-bowen
left a comment
github-bowen
left a comment
There was a problem hiding this comment.
I forgot one point. I might be better to provide local setup instructions in README, like:
export FLASK_APP=src/app.py
export PYTHONUNBUFFERED=1
export FLASK_ENV=development
python -m flask run --host=0.0.0.0 --port=8080
Member
|
@kanta8864 bro, you forgot this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through the feedbacks and the rubric to make sure that all requirements for Excellent are met. This includes
automatic release process (will test this and confirm that everything works when this branch gets merged to main)
exposing a model via REST
model-service