Conversation
remikel
reviewed
May 26, 2025
src/Entity/TypeElection.php
Outdated
| private ?int $id = null; | ||
|
|
||
| private ?string $name = null; | ||
| // private ?string $name = null; |
Collaborator
There was a problem hiding this comment.
aucune régression dû à ça ? Il me semble que ça ne s'affichait pas quelque part si je mettais pas ça
Collaborator
Author
There was a problem hiding this comment.
c'est des propriétés qui ne sont pas utilisées car elles sont dans le TypeElectionTranslation
Owner
There was a problem hiding this comment.
je sais mais si je ne les mettais pas j'avais des problème d'affichage au niveau d'easyadmin je crois. Vérifie qu'il n'y a pas de régression quand même
assets/search-election.js
Outdated
| }; | ||
|
|
||
| let apiElection = apiCall; | ||
| console.log(apiElection); |
src/Entity/TypeElection.php
Outdated
|
|
||
| #[Groups(['read'])] | ||
| public function getName(): ?string | ||
| { |
Collaborator
There was a problem hiding this comment.
c'est bizarre ça, je pense qu'il y a une façon plus propre de faire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.