Open
Conversation
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
doc/guides/getting-started.md (1)
30-40:⚠️ Potential issue | 🟠 MajorRemove obsolete
RustEventVerifier()setup from getting-started example.Line 30 and Line 39 still instruct users to use
RustEventVerifier(), which conflicts with this PR’s rust verifier removal and leaves onboarding docs broken. Please replace this with a currently available verifier/default config path (or omiteventVerifierin the quick-start snippet).Suggested doc fix
!!! -We strongly recommend using `RustEventVerifier()` for client applications. It uses a separate thread for signature verification and is therefore more performant. \ +Use the default verifier configuration unless you explicitly add an optional verifier package supported by this repo. \ !!! ```dart import 'package:ndk/ndk.dart'; @@ final ndk = Ndk( NdkConfig( - eventVerifier: RustEventVerifier(), cache: MemCacheManager(), ), );🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@doc/guides/getting-started.md` around lines 30 - 40, The docs still reference the removed RustEventVerifier() in the Ndk quick-start; update the getting-started example to remove the obsolete eventVerifier line (or replace it with a current verifier) so the snippet using Ndk and NdkConfig compiles; specifically edit the example that constructs Ndk(NdkConfig(...)) to drop eventVerifier: RustEventVerifier() and leave cache: MemCacheManager() (or substitute a supported verifier name) so the sample matches the current API.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@doc/guides/getting-started.md`:
- Around line 30-40: The docs still reference the removed RustEventVerifier() in
the Ndk quick-start; update the getting-started example to remove the obsolete
eventVerifier line (or replace it with a current verifier) so the snippet using
Ndk and NdkConfig compiles; specifically edit the example that constructs
Ndk(NdkConfig(...)) to drop eventVerifier: RustEventVerifier() and leave cache:
MemCacheManager() (or substitute a supported verifier name) so the sample
matches the current API.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8643dc44-df35-41ab-b866-92a3f23849ec
⛔ Files ignored due to path filters (4)
packages/rust_verifier/pubspec.lockis excluded by!**/*.lockpackages/rust_verifier/rust_builder/cargokit/build_tool/pubspec.lockis excluded by!**/*.lockpackages/rust_verifier/rust_builder/rust/Cargo.lockis excluded by!**/*.lockpackages/rust_verifier/web/pkg/rust_lib_ndk_bg.wasmis excluded by!**/*.wasm
📒 Files selected for processing (73)
AI_GUIDE.mdREADME.mddoc/guides/getting-started.mddoc/library-development/index.mdmelos.yamlpackages/rust_verifier/CHANGELOG.mdpackages/rust_verifier/LICENSEpackages/rust_verifier/README.mdpackages/rust_verifier/codecov.ymlpackages/rust_verifier/flutter_rust_bridge.yamlpackages/rust_verifier/lib/data_layer/repositories/rust_lib_initializer.dartpackages/rust_verifier/lib/data_layer/repositories/verifiers/rust_event_verifier.dartpackages/rust_verifier/lib/ndk_rust_verifier.dartpackages/rust_verifier/lib/rust_bridge/api/event_verifier.dartpackages/rust_verifier/lib/rust_bridge/frb_generated.dartpackages/rust_verifier/lib/rust_bridge/frb_generated.io.dartpackages/rust_verifier/lib/rust_bridge/frb_generated.web.dartpackages/rust_verifier/pubspec.yamlpackages/rust_verifier/rust_builder/.gitignorepackages/rust_verifier/rust_builder/CHANGELOG.mdpackages/rust_verifier/rust_builder/LICENSEpackages/rust_verifier/rust_builder/README.mdpackages/rust_verifier/rust_builder/android/.gitignorepackages/rust_verifier/rust_builder/android/build.gradlepackages/rust_verifier/rust_builder/android/settings.gradlepackages/rust_verifier/rust_builder/android/src/main/AndroidManifest.xmlpackages/rust_verifier/rust_builder/cargokit/.gitignorepackages/rust_verifier/rust_builder/cargokit/LICENSEpackages/rust_verifier/rust_builder/cargokit/READMEpackages/rust_verifier/rust_builder/cargokit/build_pod.shpackages/rust_verifier/rust_builder/cargokit/build_tool/README.mdpackages/rust_verifier/rust_builder/cargokit/build_tool/analysis_options.yamlpackages/rust_verifier/rust_builder/cargokit/build_tool/bin/build_tool.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/build_tool.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/android_environment.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/artifacts_provider.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_cmake.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_gradle.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_pod.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_tool.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/builder.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/cargo.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/crate_hash.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/environment.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/logging.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/options.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/precompile_binaries.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/rustup.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/target.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/util.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/verify_binaries.dartpackages/rust_verifier/rust_builder/cargokit/build_tool/pubspec.yamlpackages/rust_verifier/rust_builder/cargokit/cmake/cargokit.cmakepackages/rust_verifier/rust_builder/cargokit/cmake/resolve_symlinks.ps1packages/rust_verifier/rust_builder/cargokit/gradle/plugin.gradlepackages/rust_verifier/rust_builder/cargokit/run_build_tool.cmdpackages/rust_verifier/rust_builder/cargokit/run_build_tool.shpackages/rust_verifier/rust_builder/ios/Classes/dummy_file.cpackages/rust_verifier/rust_builder/ios/rust_lib_ndk.podspecpackages/rust_verifier/rust_builder/linux/CMakeLists.txtpackages/rust_verifier/rust_builder/macos/Classes/dummy_file.cpackages/rust_verifier/rust_builder/macos/rust_lib_ndk.podspecpackages/rust_verifier/rust_builder/pubspec.yamlpackages/rust_verifier/rust_builder/rust/.gitignorepackages/rust_verifier/rust_builder/rust/Cargo.tomlpackages/rust_verifier/rust_builder/rust/src/api/event_verifier.rspackages/rust_verifier/rust_builder/rust/src/api/mod.rspackages/rust_verifier/rust_builder/rust/src/frb_generated.rspackages/rust_verifier/rust_builder/rust/src/lib.rspackages/rust_verifier/rust_builder/windows/.gitignorepackages/rust_verifier/rust_builder/windows/CMakeLists.txtpackages/rust_verifier/web/pkg/package.jsonpackages/rust_verifier/web/pkg/rust_lib_ndk.js
💤 Files with no reviewable changes (71)
- packages/rust_verifier/LICENSE
- README.md
- AI_GUIDE.md
- packages/rust_verifier/rust_builder/rust/.gitignore
- packages/rust_verifier/rust_builder/rust/src/api/mod.rs
- packages/rust_verifier/flutter_rust_bridge.yaml
- packages/rust_verifier/rust_builder/ios/Classes/dummy_file.c
- packages/rust_verifier/rust_builder/macos/Classes/dummy_file.c
- packages/rust_verifier/rust_builder/cargokit/build_tool/README.md
- packages/rust_verifier/rust_builder/LICENSE
- melos.yaml
- packages/rust_verifier/rust_builder/README.md
- packages/rust_verifier/rust_builder/cargokit/build_tool/analysis_options.yaml
- packages/rust_verifier/rust_builder/cargokit/.gitignore
- packages/rust_verifier/rust_builder/cargokit/build_tool/pubspec.yaml
- packages/rust_verifier/codecov.yml
- packages/rust_verifier/rust_builder/cargokit/build_tool/bin/build_tool.dart
- packages/rust_verifier/rust_builder/android/src/main/AndroidManifest.xml
- packages/rust_verifier/rust_builder/windows/.gitignore
- packages/rust_verifier/CHANGELOG.md
- packages/rust_verifier/rust_builder/android/.gitignore
- packages/rust_verifier/rust_builder/.gitignore
- packages/rust_verifier/lib/data_layer/repositories/rust_lib_initializer.dart
- packages/rust_verifier/rust_builder/cargokit/LICENSE
- packages/rust_verifier/rust_builder/cargokit/README
- packages/rust_verifier/rust_builder/macos/rust_lib_ndk.podspec
- packages/rust_verifier/rust_builder/linux/CMakeLists.txt
- packages/rust_verifier/web/pkg/package.json
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_cmake.dart
- packages/rust_verifier/rust_builder/pubspec.yaml
- packages/rust_verifier/rust_builder/cargokit/build_pod.sh
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/logging.dart
- packages/rust_verifier/README.md
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/environment.dart
- packages/rust_verifier/rust_builder/cargokit/cmake/cargokit.cmake
- packages/rust_verifier/rust_builder/rust/src/lib.rs
- packages/rust_verifier/rust_builder/cargokit/run_build_tool.cmd
- packages/rust_verifier/pubspec.yaml
- packages/rust_verifier/lib/data_layer/repositories/verifiers/rust_event_verifier.dart
- packages/rust_verifier/rust_builder/windows/CMakeLists.txt
- packages/rust_verifier/lib/rust_bridge/frb_generated.web.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_gradle.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/verify_binaries.dart
- packages/rust_verifier/rust_builder/cargokit/run_build_tool.sh
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/cargo.dart
- packages/rust_verifier/rust_builder/cargokit/cmake/resolve_symlinks.ps1
- packages/rust_verifier/rust_builder/rust/Cargo.toml
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/crate_hash.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/rustup.dart
- packages/rust_verifier/rust_builder/rust/src/frb_generated.rs
- packages/rust_verifier/lib/rust_bridge/api/event_verifier.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/target.dart
- packages/rust_verifier/rust_builder/android/settings.gradle
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/build_tool.dart
- packages/rust_verifier/rust_builder/android/build.gradle
- packages/rust_verifier/rust_builder/rust/src/api/event_verifier.rs
- packages/rust_verifier/rust_builder/cargokit/gradle/plugin.gradle
- packages/rust_verifier/rust_builder/CHANGELOG.md
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/android_environment.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_tool.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/artifacts_provider.dart
- packages/rust_verifier/rust_builder/ios/rust_lib_ndk.podspec
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/builder.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/build_pod.dart
- packages/rust_verifier/lib/rust_bridge/frb_generated.io.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/util.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/options.dart
- packages/rust_verifier/rust_builder/cargokit/build_tool/lib/src/precompile_binaries.dart
- packages/rust_verifier/lib/ndk_rust_verifier.dart
- packages/rust_verifier/lib/rust_bridge/frb_generated.dart
- packages/rust_verifier/web/pkg/rust_lib_ndk.js
1-leo
requested changes
Mar 24, 2026
|
|
||
| ## Getting started with NDK helper packages | ||
|
|
||
| ### Prerequisites `ndk_rust_verifier` |
Contributor
There was a problem hiding this comment.
We need to keep this part of the docs. Installing rust+tool chains is necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit