Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 76.54% 73.86% -2.69%
==========================================
Files 152 154 +2
Lines 6377 6714 +337
==========================================
+ Hits 4881 4959 +78
- Misses 1496 1755 +259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
reviewed
Mar 2, 2026
Contributor
1-leo
left a comment
1-leo
left a comment
There was a problem hiding this comment.
Have you tested the need for dedicated caching, or is the events cache sufficient for this?
| } | ||
|
|
||
| // Close subscriptions when stream is cancelled | ||
| controller.onCancel = () async { |
Contributor
There was a problem hiding this comment.
should also close all on close
| /// [providers] - Optional list of providers to use. If null, uses default providers. | ||
| /// | ||
| /// Returns [Nip85UserMetrics] or null if no assertion found. | ||
| Future<Nip85UserMetrics?> getUserMetrics( |
Contributor
There was a problem hiding this comment.
the default could be the streaming method and the future could be just a stream.toList()
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.