Update Capturer.cs - new points + gradient #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new mapping for the points where pixel colors are captured. Fixed the incorrect left and bottom segments positioning. Rewrote the frame generation function for the image—now it uses rectangles filled with a linear gradient according to the colors captured from the screen pixels.
|
Yeah, I'm having the same problem, so really looking forward to this change being added to the main branch. |
GaetanPierre
reviewed
Mar 1, 2025
GaetanPierre
left a comment
GaetanPierre
left a comment
There was a problem hiding this comment.
I forked your work to test it, but I encountered some build issues.
|
|
||
| paint.Shader = shader_right; | ||
| canvas.DrawRect(new SKRect(imgWidth - borderThick, 0, imgWidth, imgHeight), paint); | ||
|
|
There was a problem hiding this comment.
The code seems not to build. Maybe there is a missing '}' here ?
| image.SetPixel(x, y, sKColor); | ||
| } | ||
| } | ||
| SKColor[] skColors = colors.Select(ClampColor).ToArray(); |
There was a problem hiding this comment.
It seems to be missing "using System.Linq;" as well to build properly
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new mapping for the points where pixel colors are captured. Fixed the incorrect left and bottom segments positioning. Rewrote the frame generation function for the image—now it uses rectangles filled with a linear gradient according to the colors captured from the screen pixels.
