Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the VPN build process by addressing dependency changes and transitioning the build process to a Docker-based approach.
- Update tokio-vsock dependency from "0" to "0.6.0".
- Modify the build workflow by replacing a direct run of a package script with a Docker build and run sequence.
- Update usage of vsock-related APIs in src/guest.rs and src/host.rs to align with new API requirements.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/build.yml | Changed build steps to use Docker build and run commands for packaging. |
| Cargo.toml | Upgraded tokio-vsock dependency version to 0.6.0. |
| src/guest.rs | Adapted vsock listener binding and adjusted parameter mutability. |
| src/host.rs | Updated vsock stream API usage to use VsockAddr and into_split(). |
Files not reviewed (1)
- Dockerfile: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes up some smaller issues in dependency changes in tokio-vsock.
Further, it changes our build process by moving things into a dockerfile. This helps us to target mips with verions @ rust 1.7.0 while maintaining all other targets at later rust versions.