Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary fixes to make the arm64 builds work for
fw2tar. This change was all that was required to make the docker build succeed, but I still have the question of "what is the proper way to add arm64 image builds to CI?" since right now the actions are all ran onrehosting-arc.There are a few options, I think the least work for you guys would be one of these two options:
publish.yamljobs logic without therehosting-arcspecific stuffrehosting-arcspecific logic if theruns-on:matrix target isrehosting-arcWould either of the above be something you are open to? My only real end goal here is to get
arm64docker images offw2tarpushed to dockerhub. In-house I'm building them fine but I don't want to have to continue to maintain different logic forfw2tarif I don't have to.LMK and I can add the proper changeset!