Skip to content

Many fixes: Fix CI/CD; Output from failed extractors; preserve minor numbers in firmware output names#44

Merged
zestrada merged 21 commits intomainfrom
small_fixes
Jul 30, 2025
Merged

Many fixes: Fix CI/CD; Output from failed extractors; preserve minor numbers in firmware output names#44
zestrada merged 21 commits intomainfrom
small_fixes

Conversation

@zestrada
Copy link
Member

@zestrada zestrada commented Jul 26, 2025

This PR has two commits that cleanup the following functionality:

  1. If an extractor fails, --loud now gives stdout/stderr from that extractor. I did propagate the verbose parameter throughout. If we want more things, maybe we should just push args around?
  2. The extension trimming logic could be double applied, eliding minor version numbers when making output files. The new change should be closer to the original python behavior

And also changes CI/CD to match penguin's current setup.

@zestrada zestrada changed the title Output from failed extractors; preserve minor numbers in firmware output names Many fixes: Fix CI/CD; Output from failed extractors; preserve minor numbers in firmware output names Jul 28, 2025
@zestrada
Copy link
Member Author

I realize scope is creeping here...

@zestrada
Copy link
Member Author

zestrada commented Jul 29, 2025

As part of these changes, the test output is now a json representation of the rootfs.tar.gz metadata. Had some issues with ordering and output spacing differing. Figured structured data would help and be decently future-proof.

Since that's a redo of the baselines the .old.json files were generated using the most recent stable image (rehosting/fw2tar:2.0.4).

@zestrada
Copy link
Member Author

zestrada commented Jul 30, 2025

Also tested on fw2tar 2.0.1 (what rehosting/penguin) is currently using and against various rehostings. Will test publish workflow next.

@zestrada zestrada merged commit bb9e88a into main Jul 30, 2025
1 check passed
@zestrada zestrada deleted the small_fixes branch July 30, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants