Many fixes: Fix CI/CD; Output from failed extractors; preserve minor numbers in firmware output names#44
Merged
Many fixes: Fix CI/CD; Output from failed extractors; preserve minor numbers in firmware output names#44
Conversation
Member
Author
|
I realize scope is creeping here... |
Member
Author
|
As part of these changes, the test output is now a json representation of the rootfs.tar.gz metadata. Had some issues with ordering and output spacing differing. Figured structured data would help and be decently future-proof. Since that's a redo of the baselines the |
Member
Author
|
Also tested on fw2tar 2.0.1 (what rehosting/penguin) is currently using and against various rehostings. Will test publish workflow next. |
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two commits that cleanup the following functionality:
--loudnow gives stdout/stderr from that extractor. I did propagate theverboseparameter throughout. If we want more things, maybe we should just pushargsaround?And also changes CI/CD to match penguin's current setup.