auto-generate random SteamIdHashSalt if the field is left blank #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anzz1
commented
Jan 23, 2025
anzz1
commented
Jan 23, 2025
Contributor
|
hello. please, update build.yml from master to fix CI builds |
will save the result in reunion.cfg so this should only happen once falls back to the old error message if unsuccessful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #8 , added the feature proposed there, that is auto-generating a random SteamIdHashSalt in case the field is left blank.
Will save the result in reunion.cfg so this should only happen once.
If the generation fails for some reason like unable to generate random entropy, reunion.cfg is write-protected or otherwise don't have write access, etc. it falls back to the original error message. Returning success only when the generation and writing the config file is successful should make sure that the user can't be stuck in a situation where a new random salt would be created each restart.
I also avoided any additional headers or using any non-standard functions to keep the code as portable as possible.