Skip to content

Default the keys for dynamic variable binding to the set of keys on the target type #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maritaria wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Default the keys for dynamic variable binding to the set of keys on the target type #632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions regl.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,11 @@ declare namespace REGL {
*/

/* Retrieve the property `name` passed when the draw command is executed. */
prop<Props extends {}, Key extends keyof Props>(name: Key): DynamicVariable<Props[Key]>;
prop<Props extends {}, Key extends keyof Props = keyof Props>(name: Key): DynamicVariable<Props[Key]>;
/* Retrieve the context property `name` when the draw command is executed. */
context<Context extends REGL.DefaultContext, K extends keyof Context>(name: K): DynamicVariable<Context[K]>;
context<Context extends REGL.DefaultContext, K extends keyof Context = keyof Context>(name: K): DynamicVariable<Context[K]>;
/* Retrieve the property `name` of the object in whose context the draw command is executing. */
this<This extends {}, Key extends keyof This>(name: Key): DynamicVariable<This[Key]>;
this<This extends {}, Key extends keyof This = keyof This>(name: Key): DynamicVariable<This[Key]>;

/* Drawing */

Expand Down