Implement touch event rotate + "pinch to zoom"#18
Open
MaxBittker wants to merge 5 commits intoregl-project:masterfrom
Open
Implement touch event rotate + "pinch to zoom"#18MaxBittker wants to merge 5 commits intoregl-project:masterfrom
MaxBittker wants to merge 5 commits intoregl-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy new years!
Note: you probably want to review just the first three commits. I can back out the lint fix commit!
fixes #17
Try it out at https://maxbittker.github.io/regl-camera/
I think I handled some of the edge cases and it seems to work well for my needs.
Tested on chrome on linux (touchscreen laptop) and safari ios.
How do you feel about the "quick and dirty" manual style of this implementation, versus the way that the rest of the library delegates to other packages?
Let me know what I can do to help get this to a state that you would feel good about merging :)
On the other hand, no pressure to accept this or review it on any timely manner, I want to be helpful but understand the overhead of merging new functionality to a working library! I'm happy to let this live as a fork.