changed tempfile naming, added some debugging and fixed a typo#23
Open
magenbrot wants to merge 3 commits intoregilero:masterfrom
Open
changed tempfile naming, added some debugging and fixed a typo#23magenbrot wants to merge 3 commits intoregilero:masterfrom
magenbrot wants to merge 3 commits intoregilero:masterfrom
Conversation
Owner
|
Hello, that's effectively a problem. Thanks for writing a fix. |
Contributor
Author
|
you're right. I'll change that |
* bumped version to 1.2 * updating CHANGELOG and README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @regilero,
I've had a problem while using your check. The temporary file was created with the hostname given as argument. This leads to problems when you have more than one PHP-FPM pool, since all data was written to the same file when using multiple checks.
I've changed the $TempFile variable to use the $Pool from the status page result.
Additionally I added some more debugging and fixed a typo.