Skip to content

chore: fix duplicate package.json field, update gitignore and docs#66

Open
brawlaphant wants to merge 1 commit intoregen-network:mainfrom
brawlaphant:pr/gitignore-and-housekeeping
Open

chore: fix duplicate package.json field, update gitignore and docs#66
brawlaphant wants to merge 1 commit intoregen-network:mainfrom
brawlaphant:pr/gitignore-and-housekeeping

Conversation

@brawlaphant
Copy link
Copy Markdown
Contributor

Summary

  • package.json: Remove duplicate "type": "module" field (appeared on both line 4 and line 6)
  • .gitignore: Add Python (__pycache__/, *.pyc, *.pyo, .venv/, *.egg-info/, dist/, build/) and Rust/CosmWasm (target/, *.wasm) patterns in preparation for PR feat: cadCAD economic simulations for M012-M015 parameter validation #58 cadCAD simulation code
  • README.md: Replace placeholder license section with Apache 2.0 (code) + CC BY-SA 4.0 (docs) links
  • docs/DEV_SETUP.md: Add verify:m010:datasets npm script to the table; add M012, M013, M015 reference implementation self-test examples

Test plan

  • node scripts/verify.mjs still passes
  • npm run verify:m010:datasets runs correctly
  • Confirm package.json parses without errors (node -e "require('./package.json')" or JSON.parse)
  • Verify .gitignore patterns exclude expected files

🤖 Generated with Claude Code

- Remove duplicate "type": "module" field from package.json
- Add Python and Rust/CosmWasm build artifact patterns to .gitignore
- Update README.md license section with Apache 2.0 and CC BY-SA 4.0
- Add verify:m010:datasets script row and M012/M013/M015 self-test
  examples to docs/DEV_SETUP.md

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on repository maintenance and developer experience improvements. It addresses minor configuration issues, enhances the .gitignore file to support upcoming Python and Rust/CosmWasm development, and updates documentation to provide clearer licensing details and more comprehensive setup instructions for running various mechanism self-tests. These changes streamline the development workflow and prepare the project for broader language support.

Highlights

  • Configuration Fix: Removed a duplicate 'type' field in package.json to ensure correct parsing and avoid redundancy.
  • Development Environment Setup: Updated .gitignore to include common Python and Rust/CosmWasm build artifacts, preparing the repository for future multi-language development.
  • Documentation Updates: Clarified licensing information in README.md, specifying Apache 2.0 for code and CC BY-SA 4.0 for documentation. Also, added a new npm script and self-test examples for M012, M013, and M015 mechanisms in DEV_SETUP.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to include Python and Rust/CosmWasm build artifacts, clarifies licensing details in README.md, and enhances docs/DEV_SETUP.md with a new verification script for M010 datasets and instructions for running self-tests for M012, M013, and M015 mechanisms. A review comment highlights a duplicate 'type': 'module' field in package.json that should be removed to maintain valid JSON.

"private": true,
"type": "module",
"version": "0.0.0",
"type": "module",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The package.json file contains a duplicate "type": "module" field. While some parsers might be lenient, having duplicate keys in a JSON object is invalid and can lead to unpredictable behavior. Removing the duplicate entry ensures the file is well-formed and correctly parsed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging — this PR is the fix for that exact issue. The diff shows the duplicate "type": "module" being removed (the - line). After this PR merges, package.json will have exactly one "type": "module" field on line 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant