Conversation
Fixes bullet points going outside callout card in steering geometry
Fixes link in rigid body kinematics
Fixes links and LaTeX in geometric properties
Fixes links in contact and rolling
Fixes links in work and energy and removes accidental derivation
Fixes link in momentum
|
Make sure to add documentation in the style guide for how to link to examples and warnings |
Fixes link to figure in particle kinematics
Fixes more links in rigid body kinematics
Fixes more links in geometric properties
Adds documentation for warning and example links to the style guide
mrhoyle2
left a comment
mrhoyle2
left a comment
There was a problem hiding this comment.
If I found link issues that were on the page, but not in the sections you changed, I put the line number of the link in the comment for the page overall. Please emoji react or respond each comment requesting a change to track what's been fixed.
|
|
||
| </SubSubSection> | ||
|
|
||
| <SubSubSection title = "Links to Warnings" id = "links_to_warnings"> |
There was a problem hiding this comment.
Can you add these subsubsections to the navtree for this page?
There was a problem hiding this comment.
There are a couple of places where it says "figure #id" and it is unclear to the reader what figure it is referring to. Please change the displayed text to indicate more clearly the figure being referenced.
line 495 and 500: links to wrong equation
line 510: link doesn't work
lines 656 and 666: #rvi-es reword so its clear you're leaving the pages, or link to an existing equation
There was a problem hiding this comment.
Line 471: link does not work
line 855: please change the link to something more specific on that page.
line 926: link does not work
| <SubSubSection title="Simplified shapes" id="simple_shapes_com"> | ||
| <p> | ||
| The centers of mass listed below are all special cases of the basic shapes given in Section <a href="#rcm-bs">#rcm-bs</a>. Other | ||
| The centers of mass listed below are all special cases of the basic shapes given in Section <a href="/dyn/geometric_properties#basic_shapes_com">#rcm-bs</a>. Other |
There was a problem hiding this comment.
Can you change the "#id" to the name of the section?
| <div slot="derivation"> | ||
| <p> | ||
| See <a href="#rcm-xc">example problem</a> on how to derive it by directly computing the integrals. | ||
| See <a href="/dyn/geometric_properties#example_btn_rcm-xc">example problem</a> on how to derive it by directly computing the integrals. |
There was a problem hiding this comment.
Can you make the text clearer for which example problem?
| <p> | ||
| We begin by observing that the sign conventions in | ||
| Figure <a href="#rko-ff">#rko-ff</a> mean that | ||
| Figure <a href="#rolling_flat_surface">#rko-ff</a> mean that |
There was a problem hiding this comment.
Please make the text clear which figure is being referred to
There was a problem hiding this comment.
line 246: link doesn't work
line 330: does not work
There was a problem hiding this comment.
128: wrong link
652: move container to top of section
657: 404 link error
661: Can we embed this video?
There was a problem hiding this comment.
222: container moved to top of section
249: no link
250: video unavailable. If you find a new link to put here, can we embed the video?
269: can we embed the link?
2 participants
Fixes dynamics links through the momentum page
Links pointing towards warnings and examples do not work (in progress)
In rigid body kinematics, #rkf-cf under #rkc-xlc goes nowhere in both the live pages and the original pages, seems to be very missing material
In work and energy, #ren-ep under #ren-wk goes nowhere in both the live pages and the original pages, seems to be very missing material