Make the markdown lib dependencies as a default and editable option#47
Make the markdown lib dependencies as a default and editable option#47emagnier wants to merge 1 commit intorefactory-id:masterfrom
Conversation
|
I have used bootstrap markdown with custom parser. This changes will make the editor library less extendable for non-markdown parser which undesired (from my perspective). Thanks for the effort thought. |
|
I'm not sure to understand well your point here. I just moved the call of these hardcoded dependencies to the default options. So if needed, it just give an additional way to redefine our custom dependencies without have to define a I think it's going in the same direction that discussion: #9. |
|
@toopay if you have time, could you reconsider my PR or give me some details how I can set a custom parser on a specific markdown-editor? And without have to modify directly |
|
@emagnier There are many changes already happens, so if you still interested to work on this patch, we will need to clean and rebase it with current head. My previous point was, while this editor is intentionally build for markdown, but current design still allow this editor to be extended with any parser they wish. To keep this generic behaviour, lets not use |
|
@toopay Sure thing! I may have some time to look at it during the weekend. |
|
@emagnier Great. |
This adds 2 additional options, that give the possibility to use any markdown library we want.
E.g.:
By default these 2 options still use
markdown-jsormarked(so it's backward compatible with previous editor versions).It should also fix #9.